[STUMP] [PATCH] fix xinerama

[m***@uni-rostock.de]

Hi list,

the latest changes in git broke stumpwm for me.
I use a dual-head setup.
The last known good version is cc5ba9e.
The following patch, applied to b740b04 fixed the issue.

Regards,
Matthias

---
head.lisp | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/head.lisp b/head.lisp
index 0dab8dd..12b7316 100644
--- a/head.lisp
+++ b/head.lisp
@@ -31,19 +31,19 @@

(defun screen-info-head (screen-info)
"Transform SCREEN-INFO structure from CLX to a HEAD structure from StumpWM."
- (make-head :number (xlib/xinerama:screen-info-number screen-info)
- :x (xlib/xinerama:screen-info-x screen-info)
- :y (xlib/xinerama:screen-info-y screen-info)
- :width (xlib/xinerama:screen-info-width screen-info)
- :height (xlib/xinerama:screen-info-height screen-info)
+ (make-head :number (xlib.xinerama:screen-info-number screen-info)
+ :x (xlib.xinerama:screen-info-x screen-info)
+ :y (xlib.xinerama:screen-info-y screen-info)
+ :width (xlib.xinerama:screen-info-width screen-info)
+ :height (xlib.xinerama:screen-info-height screen-info)
:window nil))

(defun make-screen-heads (screen root)
(declare (ignore screen))
(cond ((and (xlib:query-extension *display* "XINERAMA")
- (xlib/xinerama:xinerama-is-active *display*))
+ (xlib.xinerama:xinerama-is-active *display*))
(mapcar 'screen-info-head
- (xlib/xinerama:xinerama-query-screens *display*)))
+ (xlib.xinerama:xinerama-query-screens *display*)))
(t (list (make-head :number 0 :x 0 :y 0
:width (xlib:drawable-width root)
:height (xlib:drawable-height root)

[Joram Schrijver]

Hello,

In recent versions of CLX, since about 10 months ago[1], the Xinerama
package is called `xlib/xinerama`. Your patch would thus break the
build. A better idea would be to use the package name `xinerama`, which
has been there since the beginning. I'll fix that tonight.

[1]:
https://github.com/sharplispers/clx/commit/53fd7a0ff1b4274c914deb22ea6d40b9d933aae9

--
Joram

Post by m***@uni-rostock.de
Hi list,
the latest changes in git broke stumpwm for me.
I use a dual-head setup.
The last known good version is cc5ba9e.
The following patch, applied to b740b04 fixed the issue.
Regards,
Matthias
---
head.lisp | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/head.lisp b/head.lisp
index 0dab8dd..12b7316 100644
--- a/head.lisp
+++ b/head.lisp
@@ -31,19 +31,19 @@
(defun screen-info-head (screen-info)
"Transform SCREEN-INFO structure from CLX to a HEAD structure from StumpWM."
- (make-head :number (xlib/xinerama:screen-info-number screen-info)
- :x (xlib/xinerama:screen-info-x screen-info)
- :y (xlib/xinerama:screen-info-y screen-info)
- :width (xlib/xinerama:screen-info-width screen-info)
- :height (xlib/xinerama:screen-info-height screen-info)
+ (make-head :number (xlib.xinerama:screen-info-number screen-info)
+ :x (xlib.xinerama:screen-info-x screen-info)
+ :y (xlib.xinerama:screen-info-y screen-info)
+ :width (xlib.xinerama:screen-info-width screen-info)
+ :height (xlib.xinerama:screen-info-height screen-info)
:window nil))
(defun make-screen-heads (screen root)
(declare (ignore screen))
(cond ((and (xlib:query-extension *display* "XINERAMA")
- (xlib/xinerama:xinerama-is-active *display*))
+ (xlib.xinerama:xinerama-is-active *display*))
(mapcar 'screen-info-head
- (xlib/xinerama:xinerama-query-screens *display*)))
+ (xlib.xinerama:xinerama-query-screens *display*)))
(t (list (make-head :number 0 :x 0 :y 0
:width (xlib:drawable-width root)
:height (xlib:drawable-height root)
--
2.1.4
_______________________________________________
Stumpwm-devel mailing list
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel

[m***@uni-rostock.de]

Hi Joram,

Post by Joram Schrijver
Hello,
In recent versions of CLX, since about 10 months ago[1], the Xinerama
package is called `xlib/xinerama`. Your patch would thus break the
build. A better idea would be to use the package name `xinerama`, which
has been there since the beginning. I'll fix that tonight.

So, this means that CLX in debian stable is too old. Ok.
Your idea sounds fine to me.
Thank you.

Regards,
Matthias

[m***@uni-rostock.de]

Hi Joram,

Post by Joram Schrijver
I'll fix that tonight.

Sorry for the late reply.
The fix works.
Thank you.

Matthias

[Patricio Martinez]

I love stumpwm and I use two monitores. Thank you very much

Post by m***@uni-rostock.de
Hi Joram,

Post by Joram Schrijver
I'll fix that tonight.

Sorry for the late reply.
The fix works.
Thank you.
Matthias
_______________________________________________
Stumpwm-devel mailing list
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel